Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use formatter cache #212

Merged
merged 2 commits into from
Feb 28, 2017
Merged

Use formatter cache #212

merged 2 commits into from
Feb 28, 2017

Commits on Feb 27, 2017

  1. Return lua errors not falco_exceptions 

    In C functions that implement lua functions, don't directly throw
falco_exceptions, which results in opaque error messages like:

Mon Feb 27 10:09:58 2017: Runtime error: Error invoking function output:
C++ exception. Exiting.

Instead, return lua errors via lua_error().
    @mstemm
    mstemm committed Feb 27, 2017
    Configuration menu
    Copy the full SHA
    fb36af1 View commit details
    Browse the repository at this point in the history

  2. Use sysdig's formatter cache. 

    Use the sinsp_evt_formatter_cache added in
draios/sysdig#771 instead of a local cache. This
simplifies the lua side quite a bit, as it only needs to call
format_output(), and clean up everything via free_formatters() in
output_cleanup().

On the C side, use a sinsp_evt_formatter object and use it in
format_event().
    @mstemm
    mstemm committed Feb 27, 2017
    Configuration menu
    Copy the full SHA
    db469c6 View commit details
    Browse the repository at this point in the history