Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules: add OpenSSH private key to macro private_key_or_password #2284

Merged
merged 1 commit into from Dec 15, 2022

Conversation

oscr
Copy link
Contributor

@oscr oscr commented Nov 9, 2022

What type of PR is this?

/kind feature
/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

I noticed the rules macro private_key_or_password didn't check for OpenSSH private keys so I added it.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rules(macro: private_key_or_password): now also check for OpenSSH private keys 

@poiana
Copy link

poiana commented Nov 9, 2022

Welcome @oscr! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana added the size/XS label Nov 9, 2022
Signed-off-by: Oscar Utbult <oscar.utbult@gmail.com>
@darryk10
Copy link
Contributor

darryk10 commented Nov 9, 2022

LGTM

Copy link
Contributor

@darryk10 darryk10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing. It looks good to me 👍🏻

@poiana
Copy link

poiana commented Nov 9, 2022

LGTM label has been added.

Git tree hash: 8d96c525a0118653786e3b953a4ef0b576657772

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@jasondellaluce
Copy link
Contributor

/milestone 0.34.0

@poiana poiana added this to the 0.34.0 milestone Nov 10, 2022
@poiana
Copy link

poiana commented Nov 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: darryk10, jasondellaluce, Kaizhe, leogr, oscr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member

leogr commented Dec 15, 2022

Closing and reopening to trigger the CI
/close

@poiana poiana closed this Dec 15, 2022
@poiana
Copy link

poiana commented Dec 15, 2022

@leogr: Closed this PR.

In response to this:

Closing and reopening to trigger the CI
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member

leogr commented Dec 15, 2022

/reopen

@poiana poiana reopened this Dec 15, 2022
@poiana
Copy link

poiana commented Dec 15, 2022

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana merged commit f43e6c4 into falcosecurity:master Dec 15, 2022
@oscr oscr deleted the add-openssh branch December 15, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants