Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(unit_tests): try making test_configure_interesting_sets more robust #2464

Merged
merged 1 commit into from Apr 4, 2023

Conversation

incertum
Copy link
Contributor

@incertum incertum commented Apr 3, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

@jasondellaluce still getting errors locally with current master, e.g.

[----------] Global test environment tear-down
[==========] 30 tests from 9 test suites ran. (3009 ms total)
[  PASSED  ] 28 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] ConfigureInterestingSets.selection_not_allevents
[  FAILED  ] ConfigureInterestingSets.selection_allevents

 2 FAILED TESTS
[]$ git status
nothing to commit, working tree clean
[]$ git log
commit 0b6e243582c0e467efb6c2355259c4eefaa28c91 (HEAD -> master, upstream/master)

Have been reading more about it and everywhere people warn that gtests can influence each other. SetUp and TearDown didn't do anything, oddly just changing some variable names per test did help 🤷‍♀️ ... now everything is passing again locally. Unsure if it's now also just random or really helped, at the same time these changes won't hurt at all. Let's see if the CI remains intact.

Also experimented with adding a generic syscall such as init_module to the s_sample_filters ... let's try adding it after the final libs patch to make sure we get consistent new / final behavior throughout.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

cleanup(unit_tests): try making test_configure_interesting_sets more robust

…robust

Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/milestone 0.35.0

@poiana poiana added this to the 0.35.0 milestone Apr 4, 2023
@poiana poiana added the lgtm label Apr 4, 2023
@poiana
Copy link

poiana commented Apr 4, 2023

LGTM label has been added.

Git tree hash: d9bae7e53c6864c570c64906025fe0b8cb737dc6

@poiana poiana added the approved label Apr 4, 2023
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Apr 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, incertum, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 306d76d into falcosecurity:master Apr 4, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants