Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): escape heredoc #2521

Merged
merged 1 commit into from May 2, 2023
Merged

fix(ci): escape heredoc #2521

merged 1 commit into from May 2, 2023

Conversation

LucaGuerra
Copy link
Contributor

@LucaGuerra LucaGuerra commented Apr 28, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area CI

What this PR does / why we need it:

The heredoc was taken from CircleCI but apparently the escaping rules are different from GHA, so we don't need the backslash there.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Luca Guerra <luca@guerra.sh>
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks! Great catch!

@poiana
Copy link

poiana commented Apr 28, 2023

LGTM label has been added.

Git tree hash: d3105d2f6f066ead529c1bede6a9988c1d65c36f

@FedeDP
Copy link
Contributor

FedeDP commented Apr 28, 2023

/milestone 0.35.0

@poiana
Copy link

poiana commented May 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 4e25367 into master May 2, 2023
16 checks passed
@poiana poiana deleted the LucaGuerra-patch-1 branch May 2, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants