Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(ci): sign releases with cosign #2546

Merged
merged 1 commit into from May 12, 2023
Merged

new(ci): sign releases with cosign #2546

merged 1 commit into from May 12, 2023

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature
/area CI

What this PR does / why we need it:

Add signatures with cosign upon releases!

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new(release): released container images are now signed with cosign

@LucaGuerra
new(ci): sign releases with cosign
aa5a8ab 
Signed-off-by: Luca Guerra <luca@guerra.sh>
@poiana poiana requested review from FedeDP and Kaizhe May 12, 2023 12:30
@poiana poiana added the size/M label May 12, 2023
FedeDP
FedeDP approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!
/approve

@poiana poiana added the lgtm label May 12, 2023
@poiana
Copy link

poiana commented May 12, 2023

LGTM label has been added.

Git tree hash: 628462ebbb0b2cf0a06672f58822b16b245da223

@FedeDP
Copy link
Contributor

FedeDP commented May 12, 2023

/milestone 0.35.0

@poiana poiana added this to the 0.35.0 milestone May 12, 2023
@LucaGuerra
Copy link
Contributor Author

LucaGuerra commented May 12, 2023 •
edited

/hold

until the master CI passes on my previous PR :)

@FedeDP
Copy link
Contributor

FedeDP commented May 12, 2023

"Stable" is such an old-fashioned word though.
🤣

@LucaGuerra
Copy link
Contributor Author

I did edit the message 🤣

@LucaGuerra
Copy link
Contributor Author

/unhold

Andreagit97
Andreagit97 approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented May 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 92f884e into falcosecurity:master May 12, 2023
16 checks passed
@LucaGuerra LucaGuerra deleted the new/add-signature-cosign branch May 12, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeDP FedeDP FedeDP approved these changes

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

Assignees

@FedeDP FedeDP

@Andreagit97 Andreagit97

Labels
approved area/ci dco-signoff: yes kind/feature lgtm release-note size/M
Projects
Falco Roadmap
Archived in project
Milestone
0.35.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LucaGuerra @poiana @FedeDP @Andreagit97