cleanup(userspace, config): improve metrics UX, add include_empty_values option
#2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incertum
force-pushed
the
metrics-numeric-zero-config
branch
from
2c759e2
to
2a7dbff
Compare
incertum
commented
May 29, 2023
|
/milestone 0.35.0 /cc @jasondellaluce |
add send_numeric_zero_values config to allow users to save space when using metrics option, while still also allowing to send all keys (especially because we don't document the schema) Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
incertum
force-pushed
the
metrics-numeric-zero-config
branch
from
2a7dbff
to
972a66e
Compare
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com> Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
|
Thanks @jasondellaluce in addition, there was a small hiccup and n_drops_perc got misplaced somehow, moved it back out to the correct location as it was initially, PTAL. |
incertum
changed the title
send_numeric_zero_values optioninclude_empty_values option
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
jasondellaluce
approved these changes
May 31, 2023
|
LGTM label has been added. Git tree hash: c806a56385ce5bd667f75130cf84c909939bd3fe
|
leogr
approved these changes
May 31, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: incertum, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Improve metrics UX: add
send_numeric_zero_valuesconfig to allow users to save spacewhen using metrics option, while still also allowing to send all keys (especially because we don't document the schema)
@jasondellaluce will add to the falco.yaml description after rebasing given the current merge conflict with another PR.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: