Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(userspace/falco): make source matching error more expressive #2623

Merged
merged 1 commit into from Jun 21, 2023

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

chore(userspace/falco): make source matching error more expressive

Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
@jasondellaluce
Copy link
Contributor Author

/milestone 0.36.0

@poiana poiana added this to the 0.36.0 milestone Jun 7, 2023
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Jun 7, 2023

LGTM label has been added.

Git tree hash: 10d33817fa261ecbd43544871ac515d115eade67

@jasondellaluce
Copy link
Contributor Author

/milestone v0.35.1

@poiana
Copy link

poiana commented Jun 21, 2023

@jasondellaluce: The provided milestone is not valid for this repository. Milestones in this repository: [0.35.1, 0.36.0, 0.37.0]

Use /milestone clear to clear the milestone.

In response to this:

/milestone v0.35.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@FedeDP
Copy link
Contributor

FedeDP commented Jun 21, 2023

/milestone 0.35.1

@poiana poiana modified the milestones: 0.36.0, 0.35.1 Jun 21, 2023
@jasondellaluce jasondellaluce mentioned this pull request Jun 21, 2023
43 tasks
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Jun 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 7c38706 into master Jun 21, 2023
16 checks passed
@poiana poiana deleted the chore/print-source-err branch June 21, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants