Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(userspace/outputs_http): Add option for mTLS #2633

Merged
merged 1 commit into from Aug 29, 2023

Conversation

annadorottya
Copy link
Contributor

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it: Currently there is no mTLS option for the HTTP output, it would be more secure to have this feature.

Which issue(s) this PR fixes:

Fixes #2632

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new(falco/config): add new configurations for http_output that allow mTLS

@poiana
Copy link

poiana commented Jun 12, 2023

Welcome @annadorottya! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana added the size/M label Jun 12, 2023
@jasondellaluce
Copy link
Contributor

cc @alacuku

@jasondellaluce
Copy link
Contributor

/milestone 0.36.0

@poiana poiana added this to the 0.36.0 milestone Jun 12, 2023
@incertum
Copy link
Contributor

This seems very useful, are we on track to allocate time for review and feature finalization? Thank you! @leogr?

@leogr
Copy link
Member

leogr commented Aug 24, 2023

This seems very useful, are we on track to allocate time for review and feature finalization? Thank you! @leogr?

I agree this is useful. I believe we are still in time. Let's try to merge this for Falco 0.36.
cc @Andreagit97 @FedeDP

@Andreagit97
Copy link
Member

Andreagit97 commented Aug 28, 2023

I've tested it and it works, thank you for this! @annadorottya Could you rebase on master please?

leogr
leogr previously approved these changes Aug 28, 2023
@poiana
Copy link

poiana commented Aug 28, 2023

LGTM label has been added.

Git tree hash: 7903895bbe2dce8dbb042516d8f705665a24e562

Signed-off-by: Anna Simon <asimon@mercari.com>
@annadorottya
Copy link
Contributor Author

Sorry I accidentally merged the master branch into my branch, which removed the lgtm and approved labels, can you approve again @leogr ? 🙇

@incertum
Copy link
Contributor

No worries even with a direct rebase all previous approvals are removed. Leo and Andrea will approve tomorrow Europe time.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Thank you!

@poiana
Copy link

poiana commented Aug 29, 2023

LGTM label has been added.

Git tree hash: bfbf0dcf5fb2b62eb67aabb9dbd79efde8304ef3

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana merged commit c8d1637 into falcosecurity:master Aug 29, 2023
17 checks passed
@poiana
Copy link

poiana commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, annadorottya, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mTLS option to the HTTP output
7 participants