Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(falco): update the Falco base image to debian 12 #2718

Merged
merged 4 commits into from
Sep 7, 2023
Merged

new(falco): update the Falco base image to debian 12 #2718

merged 4 commits into from
Sep 7, 2023

Conversation

LucaGuerra
Copy link
Contributor

@LucaGuerra LucaGuerra commented Aug 4, 2023 •
edited
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature
/area build
/area CI

What this PR does / why we need it:

As per our discussion in #2489 and during yesterday's core maintainer call, I propose to:

  • Upgrade the Falco base image with the one that seems to build the most kernels at the moment
  • Still distribute the old one, marked as legacy, adding the necessary CI/CD job steps

Which issue(s) this PR fixes:

Fixes #2489

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update!: the Falco base image is now based on Debian 12 with gcc 11-12
new: the legacy falco image is available as driver-loader-legacy

@poiana poiana requested review from FedeDP and Kaizhe August 4, 2023 09:48
@LucaGuerra
Copy link
Contributor Author

@FedeDP I know you are not currently available but when you'll be back I would be very happy to know what you think about it :)

@leogr leogr added this to the 0.36.0 milestone Aug 11, 2023
@Andreagit97 Andreagit97 mentioned this pull request Aug 21, 2023
Closed
FedeDP
FedeDP reviewed Aug 23, 2023
View reviewed changes
docker/falco/Dockerfile Outdated Show resolved Hide resolved
FedeDP
FedeDP reviewed Aug 23, 2023
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor cleanup comment.
Everything else LGTM!

@FedeDP FedeDP mentioned this pull request Aug 29, 2023
Closed
@LucaGuerra
update(docker): upgrade Falco driver loader image
6d08e61 
Signed-off-by: Luca Guerra <luca@guerra.sh>
@LucaGuerra
update(docker): add the legacy driver loader image
71eda50 
Signed-off-by: Luca Guerra <luca@guerra.sh>
@LucaGuerra
update(build): publish the legacy driver image
df1385d 
Signed-off-by: Luca Guerra <luca@guerra.sh>
FedeDP
FedeDP previously approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Sep 5, 2023
@poiana
Copy link

poiana commented Sep 5, 2023

LGTM label has been added.

Git tree hash: cf37bb0fab00f345f37d04e2b7261cf756ac0cad

@LucaGuerra LucaGuerra mentioned this pull request Sep 5, 2023
Closed
4 tasks
@leogr leogr mentioned this pull request Sep 5, 2023
Closed
leogr
leogr reviewed Sep 5, 2023
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🤩

SGTM, just left one comment 👇

docker/falco/Dockerfile Outdated Show resolved Hide resolved
@LucaGuerra @leogr
update(docker): remove packages that are not strictly necessary
90fa73b 
Signed-off-by: Luca Guerra <luca@guerra.sh>
Co-authored-by: Leonardo Grasso <me@leonardograsso.com>
@poiana poiana removed the lgtm label Sep 6, 2023
@poiana poiana requested a review from FedeDP September 6, 2023 10:13
@LucaGuerra
Copy link
Contributor Author

Thanks @leogr ! I commend your support for improving our supply chain security 🫡 (I admit I should have thought about it first)

leogr
leogr approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 🥳

@poiana poiana added the lgtm label Sep 7, 2023
@poiana
Copy link

poiana commented Sep 7, 2023

LGTM label has been added.

Git tree hash: 602325162cb86521c2c2aa5e7c3fe829a2c24706

Andreagit97
Andreagit97 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, leogr, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,LucaGuerra,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit c2b940f into falcosecurity:master Sep 7, 2023
17 checks passed
@LucaGuerra LucaGuerra deleted the new/update-falco-base-image branch September 7, 2023 14:53
@LucaGuerra LucaGuerra mentioned this pull request Sep 7, 2023
Closed
@FedeDP FedeDP mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

@FedeDP FedeDP Awaiting requested review from FedeDP

Assignees

@leogr leogr

@FedeDP FedeDP

@Andreagit97 Andreagit97

Labels
approved area/build area/ci dco-signoff: yes kind/feature lgtm release-note size/XL
Projects
Falco Roadmap
Archived in project
Milestone
0.36.0
Development

Successfully merging this pull request may close these issues.

Discussion: Updating the default falco-driver-loader image
5 participants
@LucaGuerra @poiana @leogr @FedeDP @Andreagit97