Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove b64 from falco dependencies #2746

Merged
merged 1 commit into from Aug 30, 2023
Merged

chore: remove b64 from falco dependencies #2746

merged 1 commit into from Aug 30, 2023

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

b64 seems completely unused, i think we can remove it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

chore: remove b64 from falco dependencies

Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
@Andreagit97 Andreagit97 added this to the 0.36.0 milestone Aug 30, 2023
@poiana
Copy link

poiana commented Aug 30, 2023

LGTM label has been added.

Git tree hash: a6c6e8fc1266656e3f984ebeae4362a61521abbe

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana merged commit 988703b into master Aug 30, 2023
28 checks passed
@poiana poiana deleted the remove_b64 branch August 30, 2023 17:12
@poiana
Copy link

poiana commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants