cleanup(config): add more info #2758
Conversation
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
falco.yaml
Outdated
| # | ||
| # With Falco 0.36 and beyond, it's now possible to apply multiple rules that match | ||
| # the same event type, eliminating concerns about rule prioritization based on the | ||
| # "first match wins" principle. Read more under the `rule_matching` configuration. |
There was a problem hiding this comment.
thank you for this, I would just highlight that this has a cost in terms of perf because you have to loop on all rules every time alsp when there is a match...it should be negligible considering that most of the time no rule will match but if we want to be precise there is a penalty :)
There was a problem hiding this comment.
Yes, nice catch, we shall add this. Is it ok that I added it twice? I believe redundancy could help here.
Co-authored-by: Andrea Terzolo <andreaterzolo3@gmail.com> Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
|
LGTM label has been added. Git tree hash: ba82b38b123d280b012a6ac69799001072fefda4
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
What this PR does / why we need it:
Add more info to the config descriptions, very minor addition.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: