Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): fix reorder warning for m_watch_config_files / m_rule_matching #2767

Merged

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind cleanup
/area engine

What this PR does / why we need it:

fixes the following warning (or error when built with -Werror):

/home/ubuntu/dev/falcosecurity/falco/userspace/falco/configuration.h: In constructor ‘falco_configuration::falco_configuration()’:
/home/ubuntu/dev/falcosecurity/falco/userspace/falco/configuration.h:73:14: error: ‘falco_configuration::m_watch_config_files’ will be initialized after [-Werror=reorder]
   73 |         bool m_watch_config_files;                                                                             
      |              ^~~~~~~~~~~~~~~~~~~~                                                                              
/home/ubuntu/dev/falcosecurity/falco/userspace/falco/configuration.h:71:37: error:   ‘falco_common::rule_matching falco_configuration::m_rule_matching’ [-Werror=reorder]
   71 |         falco_common::rule_matching m_rule_matching;
      |                                     ^~~~~~~~~~~~~~~                                                            
/home/ubuntu/dev/falcosecurity/falco/userspace/falco/configuration.cpp:34:1: error:   when initialized here [-Werror=reorder]
   34 | falco_configuration::falco_configuration():                                                                    
      | ^~~~~~~~~~~~~~~~~~~           

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Luca Guerra <luca@guerra.sh>
@LucaGuerra
Copy link
Contributor Author

/milestone 0.36.0

@poiana
Copy link

poiana commented Sep 4, 2023

@LucaGuerra: You must be a member of the falcosecurity/falco-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your maintainers of falcosecurity/falco and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 0.36.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Sep 4, 2023

LGTM label has been added.

Git tree hash: 6cf22eea45a7ba6c449e2ee4b2bae3bf92c79132

@LucaGuerra
Copy link
Contributor Author

/milestone 0.36.0

@poiana poiana added this to the 0.36.0 milestone Sep 4, 2023
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Sep 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, jasondellaluce, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,LucaGuerra,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit b246bcb into falcosecurity:master Sep 4, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants