Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(userspace/engine): align %container.info defaults with new rules style #2793

Merged
merged 1 commit into from Sep 8, 2023

Conversation

leogr
Copy link
Member

@leogr leogr commented Sep 8, 2023

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

This PR aims to align the %container.info default substitution (ie. when -p is not used) with the latest rules style.

Special notes for your reviewer:

/milestone 0.36.0

Once this gets merged, documentation needs to be updated 👇
https://github.com/falcosecurity/falco-website/blob/master/content/en/docs/outputs/formatting.md?plain=1#L15

Does this PR introduce a user-facing change?:

update!: default substitution for `%container.info` is now equal `container_id=%container.id container_name=%container.name`

…ule styles

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

Copy link
Contributor

@LucaGuerra LucaGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leogr
Copy link
Member Author

leogr commented Sep 8, 2023

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

This feature does not bring any behavior changes in the Falco engine.
/hold cancel

@poiana
Copy link

poiana commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LucaGuerra,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr leogr changed the title wip: update(userspace/engine): align %container.info defaults with new rules style update(userspace/engine): align %container.info defaults with new rules style Sep 8, 2023
@poiana poiana merged commit 35cb960 into master Sep 8, 2023
19 checks passed
@poiana poiana deleted the update/container-info-default branch September 8, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants