Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dockerfile): remove useless CMD #2824

Merged
merged 1 commit into from Sep 21, 2023

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

The CMD in the docker file seems no longer useful

Which issue(s) this PR fixes:

Fixes #2818

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
@Andreagit97
Copy link
Member Author

@LucaGuerra @FedeDP

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Sep 21, 2023

LGTM label has been added.

Git tree hash: 5a5ec2154b182080a4a6f62651ba7be0ba81671f

@poiana
Copy link

poiana commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LucaGuerra
Copy link
Contributor

Thanks @Andreagit97 our hero!

@Andreagit97 Andreagit97 mentioned this pull request Sep 21, 2023
43 tasks
@poiana poiana merged commit 16a37e5 into falcosecurity:master Sep 21, 2023
17 checks passed
@Andreagit97 Andreagit97 mentioned this pull request Sep 21, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

falco-driver-loader-legacy weird logs at startup (bug?)
4 participants