chore(gha): pin versions to hashes #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Guerra <luca@guerra.sh>
|
LGTM label has been added. Git tree hash: fc7543adff61e825eb66887a5857cd1dcb426fba
|
|
Seems like one upgrade is failing. I'm checking it. |
Signed-off-by: Luca Guerra <luca@guerra.sh>
LucaGuerra
force-pushed
the
chore/pin-gha-hashes
branch
from
7996080
to
8e143b9
Compare
LucaGuerra
commented
Oct 2, 2023
| @@ -53,10 +53,11 @@ jobs: | |||
| yum install -y wget git make m4 rpm-build perl-IPC-Cmd | |||
|
|
|||
| - name: Checkout | |||
| uses: actions/checkout@v3 | |||
| # It is not possible to upgrade the checkout action to versions >= v4.0.0 because of incompatibilities with centos 7's libc. | |||
| uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0 | |||
There was a problem hiding this comment.
this is the sad downgrade (actually non-upgrade) we have to do to be compatible with centos 7. I think it's ok.
|
LGTM label has been added. Git tree hash: efb380304807b26d6e0f501a362fb5d8b5f9697f
|
leogr
approved these changes
Oct 3, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, leogr, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area CI
What this PR does / why we need it:
We have started pinning some GitHub actions to their hash, especially the ones that were based on
master. We should pin all of them. In order to limit potential breakage I have left out the actions that need a major version upgrade (except for checkout) so we can handle them in a subsequent PR.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: