fix(userspace/falco): timer_delete() workaround due to bug in older GLIBC #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LIBC Workaround for older GLIBC versions (< 2.35), where calling timer_delete() with an invalid timer ID not returned by timer_create() causes a segfault because of a bug in GLIBC (https://sourceware.org/bugzilla/show_bug.cgi?id=28257). Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
|
Can address the codespell issues at the end. |
|
Hey melissa, incidentally i just fixed that yesterday: #2850 |
|
I was going to push the branch and open the PR today :D |
|
LGTM label has been added. Git tree hash: 2fd75e3605c80666ace4832dbdc796595582ae99
|
|
/milestone 0.37.0 |
…round Co-authored-by: Federico Di Pierro <nierro92@gmail.com> Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
|
LGTM label has been added. Git tree hash: f8706bd784115d2f7071c018b86431632112bf92
|
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
|
LGTM label has been added. Git tree hash: cd405e18c83a09ff200eacb2ba0defe8e086bc51
|
Andreagit97
reviewed
Oct 5, 2023
…down Co-authored-by: Andrea Terzolo <andreaterzolo3@gmail.com> Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
|
LGTM label has been added. Git tree hash: f7ed3ff93d71840db0a90131e6627e7d706f0972
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone 0.36.1 |
This was referenced Oct 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Workaround for older GLIBC versions (< 2.35), where calling timer_delete() with an invalid timer ID not returned by timer_create() causes a segfault because of a bug in GLIBC (https://sourceware.org/bugzilla/show_bug.cgi?id=28257).
See also https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1940296.
Also verified it on:
and discovered it via backtracing using gdb debugger.
Impact: High for adopters using the metrics feature on a system with impacted GLIBC version.
@FedeDP @Andreagit97 @jasondellaluce curious, would you have a better workaround idea? Also couldn't come up with a good unit testing idea other than adding a test to the falco testing repo falcosecurity/testing#30.
Which issue(s) this PR fixes:
Fixes #2850
Special notes for your reviewer:
Does this PR introduce a user-facing change?: