build: enable compilation on win32 and macOS #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealbobo
force-pushed
the
ci/other-platforms
branch
6 times, most recently
from
ec71bd4
to
590b82f
Compare
therealbobo
force-pushed
the
ci/other-platforms
branch
6 times, most recently
from
4580d2d
to
7f7ae6b
Compare
therealbobo
changed the title
therealbobo
force-pushed
the
ci/other-platforms
branch
from
7f7ae6b
to
cc4c9f7
Compare
therealbobo
force-pushed
the
ci/other-platforms
branch
2 times, most recently
from
357e975
to
9f079b6
Compare
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
therealbobo
force-pushed
the
ci/other-platforms
branch
from
9e9299d
to
6e9bb1e
Compare
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
therealbobo
force-pushed
the
ci/other-platforms
branch
2 times, most recently
from
c156492
to
8c6a3d5
Compare
therealbobo
force-pushed
the
ci/other-platforms
branch
2 times, most recently
from
4d2d6e5
to
639ef02
Compare
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
|
LGTM label has been added. Git tree hash: 2f563f19d6894050057e4d8d656c8ab72f91a483
|
|
/milestone 0.37.0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce, therealbobo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Updated the release note label to allow the PR to get merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
/area CI
What this PR does / why we need it:
This enables falco to be build on Windows and MacOS.
Which issue(s) this PR fixes:
#2672
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: