New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(engine): clarify deprecation notice for engines #2987
cleanup(engine): clarify deprecation notice for engines #2987
Conversation
Signed-off-by: Luca Guerra <luca@guerra.sh>
/milestone 0.37.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 really like the changes!
/approve
LGTM label has been added. Git tree hash: b4d3a094d407fd2be5d50e263182f47610e5db8e
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
❤️ now I finally get what the roadmap is 😅
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, incertum, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
When I tried to start the gVisor engine I read a deprecation notice but I realized it didn't tell me what to do. This adds a bit of description there.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: