Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(config): graduate outputs_queue to stable #3016

Merged
merged 1 commit into from Jan 16, 2024

Conversation

incertum
Copy link
Contributor

@incertum incertum commented Jan 16, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

Let's discuss graduating outputs_queue to stable. If you define some reasonable limits the queue can still fill up to that limit, hence I believe it is a valuable config and supporting the queue capacity and possible future extensions in a stable manner reflects best practices.

@falcosecurity/falco-maintainers

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Jan 16, 2024

LGTM label has been added.

Git tree hash: d3a34083ba8a8455e86914aa0adbf015678ae256

@FedeDP
Copy link
Contributor

FedeDP commented Jan 16, 2024

/milestone 0.37.0

Agree with the proposed changes!

@poiana poiana added this to the 0.37.0 milestone Jan 16, 2024
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@poiana
Copy link

poiana commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, incertum, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,incertum,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit d8c368b into falcosecurity:master Jan 16, 2024
28 checks passed
@incertum incertum deleted the stable-outputs-queue branch March 5, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants