Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve class initialization #3074

Merged
merged 4 commits into from
Feb 12, 2024

Commits on Feb 12, 2024

  1. fix(c++): refactor member initialization in constructor initializatio…

    …n list
    
    Reported by cppcheck
    
    Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
    
    # Conflicts:
    #	userspace/engine/falco_common.h
    sgaist committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    9c5568d View commit details
    Browse the repository at this point in the history
  2. refactor: make falco_exception a std::runtime_error

    The implementation provides more or less the same implementation
    and thus it makes more sense to base it on std::runtime_error.
    
    Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
    sgaist committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    0f074b8 View commit details
    Browse the repository at this point in the history
  3. fix(c++): move trivial initializations to declaration site

    Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
    sgaist committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    4eba3a4 View commit details
    Browse the repository at this point in the history
  4. fix(c++): add missing member initialisation to grpc server

    Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
    sgaist committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    2b76feb View commit details
    Browse the repository at this point in the history