Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added http headers option for driver download in docker images #3075

Merged
merged 1 commit into from Feb 12, 2024

Conversation

toamto94
Copy link
Contributor

@toamto94 toamto94 commented Feb 11, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:
Adds option for http-headers for driver download in docker images

Which issue(s) this PR fixes:

Fixes #3070

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
No as empty header variable will not be processed

NONE

Signed-off-by: Tom Müller <60851960+toamto94@users.noreply.github.com>
@FedeDP
Copy link
Contributor

FedeDP commented Feb 12, 2024

/milestone 0.37.1

@poiana poiana added this to the 0.37.1 milestone Feb 12, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks!

@poiana
Copy link

poiana commented Feb 12, 2024

LGTM label has been added.

Git tree hash: deae02edf09cfc0787fed0df44452082c56a43d4

@poiana
Copy link

poiana commented Feb 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, leogr, LucaGuerra, toamto94

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 8bc32d2 into falcosecurity:master Feb 12, 2024
51 checks passed
@FedeDP FedeDP mentioned this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add http-headers as flag to docker-entrypoint.sh of driver-loader, legacy and falco
5 participants