Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Some compiler warnings #3089

Merged

Conversation

federico-sysdig
Copy link
Contributor

@federico-sysdig federico-sysdig commented Feb 14, 2024

What type of PR is this?
/kind cleanup

Any specific area of the project related to this PR?
/area build

What this PR does / why we need it:
Removes some compiler warnings.

  1. Warns about overridden functions missing override.
  2. Warns about some linker flags (-Wl,-z,relro,-z,now) being used on the compilation step.

Moreover, an unneeded warning suppression, -Wno-class-memaccess, has been removed.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Federico Aponte <federico.aponte@sysdig.com>
@federico-sysdig federico-sysdig changed the title fix: Some CMake, compiler, and linker warnings fix: Some compiler warnings Feb 14, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Feb 15, 2024

LGTM label has been added.

Git tree hash: ec938c9d7f37f40994fe5f05950109626d08a91c

@Andreagit97 Andreagit97 added this to the 0.38.0 milestone Feb 15, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Feb 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, federico-sysdig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 539dac0 into falcosecurity:master Feb 15, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants