Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit Falco license info so that GitHub recognizes it #380

Merged
merged 1 commit into from
Jun 18, 2018

Conversation

eirinikos
Copy link
Contributor

Hello! 馃憢

(CCing @dankohn who has requested this work so that the license will appear correctly in https://landscape.cncf.io/selected=sysdig-falco)

(Please see the corresponding PR for the Sysdig repo: draios/sysdig#1104)

GitHub uses a library called Licensee to identify a project's license
type. It shows this information in the status bar and via the API if it
can unambiguously identify the license.

This commit updates the COPYING file so that it contains only the full
text of the GPL 2.0 license. The info that pertains to OpenSSL has now
been moved to the "License Terms" section in the README.

Collectively, these changes allow Licensee to successfully identify the
license type of Falco as GPL 2.0.

GitHub uses a library called Licensee to identify a project's license
type. It shows this information in the status bar and via the API if it
can unambiguously identify the license.

This commit updates the COPYING file so that it contains only the full
text of the GPL 2.0 license. The info that pertains to OpenSSL has now
been moved to the "License Terms" section in the README.

Collectively, these changes allow Licensee to successfully identify the
license type of Falco as GPL 2.0.

falco-CLA-1.0-signed-off-by: Andrea Kao <eirinikos@gmail.com>
@mstemm
Copy link
Contributor

mstemm commented Jun 13, 2018

Thanks, I'm checking on our side if the changes are ok to make. (Pretty sure they will be, but just checking).

In the meantime, could you edit your commit so it contains falco-CLA-1.0-... lines as described here? https://github.com/draios/falco#what-do-i-need-to-do-in-order-to-contribute-code

@eirinikos
Copy link
Contributor Author

Thanks for the note. In regards to the git commit sign-off, I'm not sure why my PR is failing the sign-off-checker.

I just double-checked my commit message to make sure that I remembered to include a sign-off. Is there something I'm missing?

@mstemm
Copy link
Contributor

mstemm commented Jun 14, 2018

Hmm, you're right, and the text in the commit looks correct to me. Let me double-check the webhook on our side.

@mstemm
Copy link
Contributor

mstemm commented Jun 18, 2018

Still trying to figure out what's up with the webhook, but in the meanwhile I'll go ahead and merge this.

@mstemm mstemm merged commit 81dcee2 into falcosecurity:dev Jun 18, 2018
@eirinikos eirinikos deleted the update-license branch June 20, 2018 00:00
@eirinikos
Copy link
Contributor Author

Thanks a lot, @mstemm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants