Fix AWS permissions for Kubernetes Response Engine #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure needed permisssions instead of using one too permissive.
Instead of giving a lot of permissions set only the needed ones
Maintain consistency between deployments
This restricts attack surface, and work better in term of automation.
|
The Regardless, I feel like the cluster-role and cluster-role-binding files should live in the same directory. |
Although it duplicates some code, we prefer duplicate some code and place this files together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honor the principle of least privilege when giving permissions for Kubernetes Response Engine and RBAC and use a system account created specifically for AWS and Kubernetes Response Engine.