Allow SSL for k8s audit endpoint #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstemm
requested changes
Nov 28, 2018
|
All the other changes look good. Let's just clean up the port handling for ssl. |
mfdii
force-pushed
the
mfdii/add_ssl_support
branch
2 times, most recently
from
bd7a973
to
f46104d
Compare
mstemm
force-pushed
the
mfdii/add_ssl_support
branch
from
a3f183c
to
9c09dd3
Compare
mstemm
approved these changes
Jan 23, 2019
Allow enabling SSL for the Kubernetes audit log web server. This required adding two new configuration options: webserver.ssl_enabled and webserver.ssl_certificate. To enable SSL add the below to the webserver section of the falco.yaml config: webserver: enabled: true listen_port: 8765s k8s_audit_endpoint: /k8s_audit ssl_enabled: true ssl_certificate: /etc/falco/falco.pem Note that the port number has an s appended to indicate SSL for the port which is how civetweb expects SSL ports be denoted. We could change this to dynamically add the s if ssl_enabled: true. The ssl_certificate is a combination SSL Certificate and corresponding key contained in a single file. You can generate a key/cert as follows: $ openssl req -newkey rsa:2048 -nodes -keyout key.pem -x509 -days 365 -out certificate.pem $ cat certificate.pem key.pem > falco.pem $ sudo cp falco.pem /etc/falco/falco.pem fix ssl option handling
Add notes on how to create the ssl certificate to the config comments.
mstemm
force-pushed
the
mfdii/add_ssl_support
branch
from
1e9e00b
to
4b0355c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow enabling SSL for the Kubernetes audit log web server. This required adding two new configuration options:
webserver.ssl_enabledandwebserver.ssl_certificate. To enable SSL add the below to thewebserversection of thefalco.yamlconfig:Note that the port number has an
sappended to indicate SSL for the port which is how civetweb expects SSL ports be denoted. We could change this to dynamically add thesifssl_enabled: true.The
ssl_certificateis a combination SSL Certificate and corresponding key contained in a single file. You can generate a key/cert as follows: