Puppet write below /etc and new user_known_x macros! #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se Puppet often manages configurations + Add the user_known_write_root_conditions macro to allow custom conditions in the "Write below root" rule + Add the user_known_non_sudo_setuid_conditions to allow custom conditions in the "Non sudo setuid" rule falco-CLA-1.0-contributing-entity: Coveo Solutions Inc. falco-CLA-1.0-signed-off-by: Jean-Philippe Lachance <jplachance@coveo.com>
|
Thanks again for the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings!
Falco is currently whitelisting multiple processes to write below
/etcand Puppet was not one of them. Adding Puppet to the list of allowedproc.namewill remove multiple false positives.On top of that, I added the
user_known_write_root_conditionsand theuser_known_non_sudo_setuid_conditionsmacros, so users can add their own condition without overriding the official Falco rules file.Changes:
proc.namewriting below etc because Puppet often manages configurationsfalco-CLA-1.0-contributing-entity: Coveo Solutions Inc.
falco-CLA-1.0-signed-off-by: Jean-Philippe Lachance jplachance@coveo.com