Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude oc on writing below root #567

Merged
merged 2 commits into from
Mar 29, 2019
Merged

exclude oc on writing below root #567

merged 2 commits into from
Mar 29, 2019

Conversation

Kaizhe
Copy link
Contributor

@Kaizhe Kaizhe commented Mar 28, 2019

No description provided.

@Kaizhe Kaizhe requested a review from mstemm March 28, 2019 21:05
mstemm
mstemm approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@mstemm mstemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d suggest changing the proc.name match to use an in (kubectl, oc) instead of two equality comparisons. Either way is correct though.

@Kaizhe
Copy link
Contributor Author

Kaizhe commented Mar 29, 2019

@mstemm done, thanks!

@Kaizhe Kaizhe merged commit 9e26117 into dev Mar 29, 2019
@fntlnz fntlnz deleted the rule-updates-2019-03.v2 branch April 7, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstemm mstemm mstemm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kaizhe @mstemm