Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude oc on writing below root #567

Merged
merged 2 commits into from Mar 29, 2019

Conversation

Projects
None yet
2 participants
@Kaizhe
Copy link
Contributor

commented Mar 28, 2019

No description provided.

@Kaizhe Kaizhe requested a review from mstemm Mar 28, 2019

@mstemm

mstemm approved these changes Mar 29, 2019

Copy link
Contributor

left a comment

I’d suggest changing the proc.name match to use an in (kubectl, oc) instead of two equality comparisons. Either way is correct though.

@Kaizhe

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

@mstemm done, thanks!

@Kaizhe Kaizhe merged commit 9e26117 into dev Mar 29, 2019

2 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.