Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix regression that broke json output #581

Merged
merged 1 commit into from
Apr 16, 2019
Merged

fix regression that broke json output #581

merged 1 commit into from
Apr 16, 2019

Conversation

mfdii
Copy link
Member

@mfdii mfdii commented Apr 16, 2019

This should fix #560. Tested and confirmed json output doesn't get escaped after multiple alerts.

@mfdii mfdii added the kind/bug label Apr 16, 2019
@mfdii mfdii requested a review from mstemm April 16, 2019 18:54
mstemm
mstemm approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@mstemm mstemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@mfdii mfdii merged commit acb582a into dev Apr 16, 2019
@mfdii mfdii deleted the mfdii/fix_json_output branch April 16, 2019 20:26
@fntlnz fntlnz mentioned this pull request Feb 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstemm mstemm mstemm approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

With json output, output field itself becomes json after first alert
2 participants
@mfdii @mstemm