Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors when building via docker from MacOS #582

Merged
merged 2 commits into from Apr 17, 2019

Conversation

Projects
None yet
2 participants
@mfdii
Copy link
Member

commented Apr 16, 2019

When using the GitHub CMake integration, it expects a real user to be present via /etc/passwd. There are ways around this when building on a linux host via the Falco docker builder container, but on a Mac it gets a bit harder. Moving cmake to use curl and pull the yamlcpp tarball via S3 removes the dependency on a local user existing.

Also, when building via the docker builder, I got warnings (which were treated as errors by GCC) about variable initialization order. Reordered the variables in question to get get rid of the errors, however I'm not sure if we need to check the compiler flags we are using in the Falco docker build container as I haven't seen this before.

@mfdii mfdii requested a review from mstemm Apr 16, 2019

@mfdii mfdii added the kind/bug label Apr 16, 2019

@mfdii mfdii force-pushed the mfdii/fix_docker_builder branch from fd597d6 to 74ff9dd Apr 16, 2019

@mfdii

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2019

@mstemm fixed my multiple commit mess. should be ready for review.

@mstemm
Copy link
Contributor

left a comment

The warnings as errors thing isn't totally new, it comes from here https://github.com/falcosecurity/falco/blob/dev/CMakeLists.txt#L22 and was added late 2018.

The other changes look good other than removing the comments.

Show resolved Hide resolved CMakeLists.txt Outdated
@mstemm

mstemm approved these changes Apr 17, 2019

@mfdii mfdii merged commit 05bb4a8 into dev Apr 17, 2019

2 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details

@mfdii mfdii deleted the mfdii/fix_docker_builder branch Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.