Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix errors when building via docker from MacOS #582
When using the GitHub CMake integration, it expects a real user to be present via /etc/passwd. There are ways around this when building on a linux host via the Falco docker builder container, but on a Mac it gets a bit harder. Moving cmake to use curl and pull the yamlcpp tarball via S3 removes the dependency on a local user existing.
Also, when building via the docker builder, I got warnings (which were treated as errors by GCC) about variable initialization order. Reordered the variables in question to get get rid of the errors, however I'm not sure if we need to check the compiler flags we are using in the Falco docker build container as I haven't seen this before.
mstemm left a comment
The warnings as errors thing isn't totally new, it comes from here https://github.com/falcosecurity/falco/blob/dev/CMakeLists.txt#L22 and was added late 2018.
The other changes look good other than removing the comments.