Rule updates 2019 05.v1 #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures a preceding not will apply to the whole macro
It looks like a lot of scripted programs (shell scripts running cp, sed, arbitrary ruby programs) are run by fluentd to set up config. They're too generic to identify, so jut add /etc/fluent/configs.d to safe_etc_dirs, sadly.
/opt/jboss/container/java/run/run-java.sh and /opt/run-java/run-java.sh write to /etc/passwd in a contaner, probably to add a user. Add an exception for them.
|
Could you add a fix for the FPs generated by |
Kaizhe
reviewed
May 1, 2019
| @@ -1029,6 +1029,13 @@ | |||
| fd.name startswith "/etc/rancher-dns") | |||
| ) | |||
|
|
|||
| - macro: jboss_in_container_writing_passwd | |||
| condition: > | |||
| ((proc.cmdline="run-java.sh /opt/jboss/container/java/run/run-java.sh" | |||
There was a problem hiding this comment.
the proc.cmdline looks strange, the args[1] is the abs path of the exe?
There was a problem hiding this comment.
It does look strange, but the policy event did have that as the full cmdline. Here's an example:
File below /etc opened for writing (user=<NA> command=run-java.sh /opt/jboss/container/java/run/run-java.sh parent=java pcmdline=java -javaagent:/opt/jboss/container/jolokia/jolokia.jar=config=/opt/jboss/container/jolokia/etc/jolokia.properties....
And for reference, the output field of that rule is:
output: "File below /etc opened for writing (user=%user.name command=%proc.cmdline parent=%proc.pname pcmdline=%proc.pcmdline file=%fd.name program=%proc.name gparent=%proc.aname[2] ggparent=%proc.aname[3] gggparent=%proc.aname[4])"
Kaizhe
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.