Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dropping mode after open so it is effective #635

Merged
merged 1 commit into from May 31, 2019

Conversation

Projects
None yet
3 participants
@mstemm
Copy link
Contributor

commented May 31, 2019

For a while, falco has set the inspector drop mode to 1, which should
discard several classes of events that weren't necessary to use most
falco rules.

However, it was mistakenly being called before the inspector was opened,
which meant it wasn't actually doing anything.

Fix this by setting the dropping mode after the inspector open.

On some spot testing on a moderately loaded environment, this results in
a 30-40% drop in the number of system calls processed per second, and
should result in a nice boost in performance.

Set dropping mode after open so it is effective
For a while, falco has set the inspector drop mode to 1, which should
discard several classes of events that weren't necessary to use most
falco rules.

However, it was mistakenly being called before the inspector was opened,
which meant it wasn't actually doing anything.

Fix this by setting the dropping mode after the inspector open.

On some spot testing on a moderately loaded environment, this results in
a 30-40% drop in the number of system calls processed per second, and
should result in a nice boost in performance.

@mstemm mstemm requested review from fntlnz and leodido May 31, 2019

@fntlnz

fntlnz approved these changes May 31, 2019

Copy link
Member

left a comment

Good catch @mstemm !

@leodido
Copy link
Member

left a comment

🔥

@mstemm mstemm merged commit 21ba0ee into dev May 31, 2019

5 checks passed

Build Build Successful
Details
Run tests All tests passed
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/jenkins/branch This commit looks good
Details

@mstemm mstemm deleted the set-dropping-mode-properly branch May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.