Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle rule patterns that are invalid regexes #636

Merged
merged 1 commit into from May 31, 2019

Conversation

Projects
None yet
2 participants
@mstemm
Copy link
Contributor

commented May 31, 2019

In the case where a rule name can't be compiled as a regex, fall back to
a substring search instead.

Handle rule patterns that are invalid regexes
In the case where a rule name can't be compiled as a regex, fall back to
a substring search instead.

@mstemm mstemm requested review from leodido and fntlnz May 31, 2019

@leodido
Copy link
Member

left a comment

Looks good to me ✔️.

@mstemm mstemm merged commit 969374f into dev May 31, 2019

5 checks passed

Build Build Successful
Details
Run tests All tests passed
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/jenkins/branch This commit looks good
Details

@mstemm mstemm deleted the capture-regex-comp-errors branch May 31, 2019

leodido added a commit that referenced this pull request May 31, 2019

Handle rule patterns that are invalid regexes (#636)
In the case where a rule name can't be compiled as a regex, fall back to
a substring search instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.