Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial owners files #658

Closed
wants to merge 26 commits into from
Closed

Initial owners files #658

wants to merge 26 commits into from

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented Jun 11, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flaky-test

If contributing rules or changes to rules, please make sure to uncomment the appropriate kind

/kind rule/update
/kind rule/create

Any specific area of the project related to this PR?

/area engine
/area rules
/area deployment
/area integrations
/area examples

What this PR does / why we need it:

Added two initial owners file for this repo, will fine tune on the go but this now allows us to assign prs.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

mstemm and others added 26 commits December 22, 2016 13:25
…G_ORC_UNWINDER or CONFIG_STACK_VALIDATION. (#362)

sysdig-CLA-1.0-signed-off-by: David Archer <darcher@gmail.com>
falco-CLA-1.0-signed-off-by: Xiang Dai <764524258@qq.com>

Signed-off-by: Xiang Dai <764524258@qq.com>
falco-CLA-1.0-signed-off-by: Xiang Dai <764524258@qq.com>
falco-CLA-1.0-signed-off-by: Xiang Dai <764524258@qq.com>1
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@poiana
Copy link

poiana commented Jun 11, 2019

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@poiana
Copy link

poiana commented Jun 11, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the size/M label Jun 11, 2019
@fntlnz fntlnz closed this Jun 11, 2019
@fntlnz fntlnz deleted the feat/initial-owners-file branch June 11, 2019 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants