Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule updates 2019 06.v4 #685

Merged
merged 4 commits into from
Jul 1, 2019
Merged

Rule updates 2019 06.v4 #685

merged 4 commits into from
Jul 1, 2019

Conversation

Kaizhe
Copy link
Contributor

@Kaizhe Kaizhe commented Jun 21, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flaky-test

If contributing rules or changes to rules, please make sure to uncomment the appropriate kind

/kind rule/update

/kind rule/create

Any specific area of the project related to this PR?

/area engine
/area rules
/area deployment
/area integrations
/area examples

What this PR does / why we need it:
Improve whitelisting to reduce false positive

Which issue(s) this PR fixes:

Fixes #

  1. add placeholder for rules write below root/etc
  2. add weaveworks/scope to whitelist in rule change thread namespace
  3. add openshift image to whitelist

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

1. add placeholder for rules write below root/etc
2. add `weaveworks/scope` to whitelist in rule change thread namespace
3. add openshift image to whitelist

Copy link
Contributor

@mstemm mstemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the know -> known suggestion.

rules/falco_rules.yaml Outdated Show resolved Hide resolved
rules/falco_rules.yaml Outdated Show resolved Hide resolved
fntlnz
fntlnz previously approved these changes Jun 23, 2019
@poiana
Copy link

poiana commented Jun 23, 2019

LGTM label has been added.

Git tree hash: e35c75f5cf1415385c6c350c08f41b927c41f460

mstemm
mstemm previously approved these changes Jun 24, 2019
mstemm
mstemm previously approved these changes Jun 25, 2019
@poiana poiana added the lgtm label Jun 25, 2019
@poiana
Copy link

poiana commented Jun 25, 2019

LGTM label has been added.

Git tree hash: 1ab6c7e57501c7e05cfb1a66bb4b28aa0df1c7e3

fntlnz
fntlnz previously approved these changes Jun 25, 2019
Signed-off-by: kaizhe <derek0405@gmail.com>
Signed-off-by: kaizhe <derek0405@gmail.com>
Signed-off-by: kaizhe <derek0405@gmail.com>
@Kaizhe Kaizhe dismissed stale reviews from fntlnz and mstemm via 8a765e2 June 28, 2019 03:59
@Kaizhe Kaizhe requested review from fntlnz and mstemm June 28, 2019 05:47
mstemm
mstemm previously approved these changes Jun 28, 2019
@poiana poiana added the lgtm label Jun 28, 2019
@poiana
Copy link

poiana commented Jun 28, 2019

LGTM label has been added.

Git tree hash: f898ca5190efd5edc904a5e7b69890e13c8a16d1

Signed-off-by: kaizhe <derek0405@gmail.com>
@poiana
Copy link

poiana commented Jun 29, 2019

LGTM label has been added.

Git tree hash: 25f52fc66ed31665b34cd40bb4549b0a4dc75403

@Kaizhe
Copy link
Contributor Author

Kaizhe commented Jul 1, 2019

@mstemm can you please merge it for me?

@poiana
Copy link

poiana commented Jul 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fntlnz fntlnz merged commit 16bd891 into dev Jul 1, 2019
@poiana poiana deleted the rule-updates-2019-06.v4 branch July 1, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants