Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PR template for kind/rule-* #697

Merged
merged 1 commit into from
Jul 1, 2019
Merged

fix PR template for kind/rule-* #697

merged 1 commit into from
Jul 1, 2019

Conversation

leodido
Copy link
Member

@leodido leodido commented Jul 1, 2019

Signed-off-by: leodidonato@gmail.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flaky-test

If contributing rules or changes to rules, please make sure to uncomment the appropriate kind

/kind rule/update
/kind rule/create

Any specific area of the project related to this PR?

/area engine
/area rules
/area deployment
/area integrations
/area examples

What this PR does / why we need it:

This is needed because Prow (and so @poiana) matches only against the first slash. Thus labels cannot contains other slashes.
There was a mismatch between the PR template and the labels kind/rule-* which I manually fixed (in the future labels will be automated).

Which issue(s) this PR fixes:

Fixes #696

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: leodidonato@gmail.com
@Kaizhe
Copy link
Contributor

Kaizhe commented Jul 1, 2019

/lgtm

@poiana
Copy link

poiana commented Jul 1, 2019

LGTM label has been added.

Git tree hash: 82739bf969b03b798d950874f54ba4d0ce5df104

@Kaizhe
Copy link
Contributor

Kaizhe commented Jul 1, 2019

/approve

@leodido
Copy link
Member Author

leodido commented Jul 1, 2019

/assign @leodido

@leodido
Copy link
Member Author

leodido commented Jul 1, 2019

/approve

@poiana poiana added the approved label Jul 1, 2019
@poiana
Copy link

poiana commented Jul 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, Kaizhe, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leodido leodido merged commit 48f2b1d into dev Jul 1, 2019
@poiana poiana deleted the leodido-fix-pr-template branch July 1, 2019 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix PR template suggestion for kind/rule-* labels
4 participants