Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(.github): PR template #699

Merged
merged 1 commit into from
Jul 1, 2019
Merged

update(.github): PR template #699

merged 1 commit into from
Jul 1, 2019

Conversation

leodido
Copy link
Member

@leodido leodido commented Jul 1, 2019

Some refinements and improvements to the GitHub PR template.

Co-authored-by: Lorenzo Fontana lo@linux.com
Signed-off-by: Leonardo Di Donato leodidonato@gmail.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test
/kind feature
/kind flaky-test

If contributing rules or changes to rules, please make sure to uncomment the appropriate kind

/kind rule-update
/kind rule-create

Any specific area of the project related to this PR?

/area engine
/area rules
/area deployment
/area integrations
/area examples

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

fntlnz
fntlnz previously approved these changes Jul 1, 2019
@poiana
Copy link

poiana commented Jul 1, 2019

LGTM label has been added.

Git tree hash: 77e3c7695b7a4bce26f235a69b528c72f696879c

@poiana poiana added the approved label Jul 1, 2019
Some refinements and improvements to the GitHub PR template.

Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@poiana
Copy link

poiana commented Jul 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Jul 1, 2019
@fntlnz fntlnz merged commit fade424 into dev Jul 1, 2019
@poiana poiana deleted the leodido-pr-template-2 branch July 1, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants