Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules update 07.v1 #733

Merged
merged 2 commits into from
Jul 23, 2019
Merged

rules update 07.v1 #733

merged 2 commits into from
Jul 23, 2019

Conversation

Kaizhe
Copy link
Contributor

@Kaizhe Kaizhe commented Jul 22, 2019

Signed-off-by: kaizhe derek0405@gmail.com

What type of PR is this?

/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

It adds trusted_logging_images macro for rule Clear Log History as exception.

Which issue(s) this PR fixes:

Add macro trusted_logging_images to rule Clear Log History

Fixes #732

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add macro `trusted_logging_images` to rule `Clear Log History`
Add netdata/netdata to `falco_sensitive_mount_images`

Add trusted_logging_images macro for rule Clear Log Hisotry as exception

Signed-off-by: kaizhe <derek0405@gmail.com>
Signed-off-by: kaizhe <derek0405@gmail.com>
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poiana
Copy link

poiana commented Jul 23, 2019

LGTM label has been added.

Git tree hash: 0a9fa19f1ee31a8a3768a746664dd12007643206

@poiana
Copy link

poiana commented Jul 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Kaizhe Kaizhe mentioned this pull request Jul 23, 2019
@leodido leodido merged commit d6c089c into dev Jul 23, 2019
@poiana poiana deleted the rule-updates-2019-07.v1 branch July 23, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Netdata to whitelist
3 participants