Rules add cadvisor node exporter #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
dco-signoff: no
needs-kind
size/XS
release-note-none
kind/feature
and removed
do-not-merge/release-note-label-needed
needs-kind
labels
|
/lgtm |
|
LGTM label has been added. Git tree hash: 2e7267428216cf430cdd2ff6b2bb5a4f8fde0cc0
|
|
@ntimo thanks for your contribution! |
|
Hey @ntimo thanks for your contrib! Can you please signoff all your commits? :) |
|
@leodido sure, just signed the commit. Sorry. |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 46c42f4d5e295046af99f0a8aa61e3aa02205b4b
|
leodido
previously approved these changes
Jul 23, 2019
Signed-off-by: Timo Nowitzki <git@nowitzki.me>
Signed-off-by: Timo Nowitzki <git@nowitzki.me>
leodido
approved these changes
Jul 24, 2019
|
LGTM label has been added. Git tree hash: 5d3a1114936a11cce8f75a730caac16e6f4f927d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kaizhe, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
This PR adds the cAdvisor and Node Expoter image to the whitelist of containers so that Falco does not report. (Rule: Launch Sensitive Mount Container)
Which issue(s) this PR fixes:
Fixes #735
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
The cAdvisor and Node Exporter containers are no longer trigger the rule: Launch Sensitive Mount Container