Fix addl rules validation errors #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make additional improvements to display relevant context when validating files. This handles cases where a macro/rule overwrites a prior rule. - Instead of saving the index into the array of lines for each rule, save the rule yaml itself, as a property 'context' for each object. - When appending rules, the context of the base macro/rule and the context of the appended rule/macro are concatenated. - New functions get_orig_yaml_obj, build_error, and build_error_with_context handle building the error string. Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
Add new tests that ensure that validation across files and involving multiple macro/rule objects display the right context. When appending, both objects are displayed. When overwriting, the overwritten object is displayed. Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
mstemm
force-pushed
the
fix-addl-rules-validation-errors
branch
from
abb135d
to
cdb30dd
Compare
leodido
approved these changes
Jul 31, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: a2805bc603ab3a3224f834049e5ba4f17d10ba6b
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
Does this PR introduce a user-facing change?: