Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule update: add exception for write below rpm (#745) #755

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@Kaizhe
Copy link
Contributor

Kaizhe commented Jul 31, 2019

Signed-off-by: kaizhe derek0405@gmail.com

What type of PR is this?

/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #745

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rules: Add exception for rule Write below rpm, this is a FP caused by amazon linux 2 yum.
Signed-off-by: kaizhe <derek0405@gmail.com>
@leodido
leodido approved these changes Aug 1, 2019
Copy link
Member

leodido left a comment

LGTM

@poiana poiana added the lgtm label Aug 1, 2019
@poiana

This comment has been minimized.

Copy link

poiana commented Aug 1, 2019

LGTM label has been added.

Git tree hash: 5ba9800bc8924a47913dfd5458f99ec99ca7bf9a

@poiana poiana added the approved label Aug 1, 2019
@mstemm
mstemm approved these changes Aug 1, 2019
@poiana

This comment has been minimized.

Copy link

poiana commented Aug 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Kaizhe Kaizhe removed the request for review from fntlnz Aug 1, 2019
@leodido leodido merged commit 3dbd437 into dev Aug 1, 2019
6 of 7 checks passed
6 of 7 checks passed
tide Not mergeable. Job Travis CI - Pull Request has not succeeded.
Build Build Successful
Details
Run tests All tests passed
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/jenkins/branch This commit looks good
Details
dco All commits have Signed-off-by
Details
@poiana poiana deleted the rule-updates-2019-07.v2 branch Aug 1, 2019
@leodido leodido added this to the 0.18.0 milestone Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.