fix: make sure that when deleting shell history the system call is taken into account

[fntlnz]

Signed-off-by: Lorenzo Fontana lo@linux.com

What type of PR is this?

/kind bug
/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

When deleting a shell history file we can't rely on the name of the command deleting it.
This PR uses the rmdir, unlink and unlinkat syscalls instead to reliably detect if an history file had been deleted.

Which issue(s) this PR fixes:
NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rules: Delete Bash History is renamed to Delete or rename shell history
rules: Delete or rename shell history: When deleting a shell history file now the syscalls are taken into account rather than just the commands deleting the files
rules: Delete or rename shell history: history deletion now supports fish and zsh in addition to bash

[Kaizhe]

/lgtm

[poiana]

LGTM label has been added.

Git tree hash: 37a61f40f869e3cd8c95dbe236e4677c9bda1083

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kaizhe, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• rules/OWNERS [Kaizhe,leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment