Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build dependencies for the local dockerfile #782

Merged
merged 1 commit into from Aug 21, 2019
Merged

Fix build dependencies for the local dockerfile #782

merged 1 commit into from Aug 21, 2019

Conversation

@fntlnz
Copy link
Member

fntlnz commented Aug 21, 2019

Signed-off-by: Lorenzo Fontana lo@linux.com
Co-Authored-By: Leonardo Di Donato leodidonato@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:
Debian unstable recently changed the dependency tree, we now need to include specific packages in the local dockerfile.

Which issue(s) this PR fixes:

Fixes #781

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: build dependencies for the local dockerfile
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
@poiana poiana requested review from leodido and mstemm Aug 21, 2019
@poiana poiana added the size/M label Aug 21, 2019
@fntlnz fntlnz changed the title fix(docker/local): fix build dependencies Fix build dependencies for the local dockerfile Aug 21, 2019
@poiana poiana added the lgtm label Aug 21, 2019
@poiana

This comment has been minimized.

Copy link

poiana commented Aug 21, 2019

LGTM label has been added.

Git tree hash: 2067788f888b6a81b2aaf98a2d3fd691979502e3

@poiana

This comment has been minimized.

Copy link

poiana commented Aug 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Aug 21, 2019
@fntlnz fntlnz merged commit 7d8e1de into dev Aug 21, 2019
6 of 7 checks passed
6 of 7 checks passed
tide Not mergeable. Job Travis CI - Pull Request has not succeeded.
Build Build Successful
Details
Run tests All tests passed
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/jenkins/branch This commit looks good
Details
dco All commits have Signed-off-by
Details
@poiana poiana deleted the fix/build-local branch Aug 21, 2019
@fntlnz fntlnz added this to the 0.18.0 milestone Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.