Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker/stable): fix libgcc-6-dev dependencies #830

Merged
merged 1 commit into from Sep 15, 2019

Conversation

@sumitsaiwal
Copy link
Contributor

sumitsaiwal commented Sep 11, 2019

added libmpx2 to be installed during apt-get install which is a dependency for dpkg: libgcc-6-dev:amd64

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area engine

/area rules

/area deployment

/area integrations

/area examples

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #814

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: stable dockerfile libgcc-6-dev dependencies
@poiana

This comment has been minimized.

Copy link

poiana commented Sep 11, 2019

Welcome @sumitsaiwal! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana requested review from Kaizhe and kris-nova Sep 11, 2019
@poiana poiana added the size/XS label Sep 11, 2019
@sumitsaiwal sumitsaiwal force-pushed the sumitsaiwal:patch-1 branch from 248d9d4 to bb922d1 Sep 11, 2019
@sumitsaiwal sumitsaiwal force-pushed the sumitsaiwal:patch-1 branch from bb922d1 to 8bfe456 Sep 11, 2019
@leodido leodido self-requested a review Sep 13, 2019
Copy link
Member

leodido left a comment

Thanks for the fix ! :)

To be able to merge this in we need you to sign-off your commit as per contributing policies. Would you mind signing your commit please? Thanks!

added `libmpx2` to be install during `apt-get install` which is a dependency for `dpkg: libgcc-6-dev:amd64`
Signed-off-by: Sumit Kumar <sumitsaiwal@gmail.com>
@sumitsaiwal sumitsaiwal force-pushed the sumitsaiwal:patch-1 branch from 8bfe456 to a501b85 Sep 14, 2019
@sumitsaiwal

This comment has been minimized.

Copy link
Contributor Author

sumitsaiwal commented Sep 14, 2019

/assign @leodido

@fntlnz
fntlnz approved these changes Sep 15, 2019
@poiana

This comment has been minimized.

Copy link

poiana commented Sep 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the lgtm label Sep 15, 2019
@poiana

This comment has been minimized.

Copy link

poiana commented Sep 15, 2019

LGTM label has been added.

Git tree hash: b40e377cc0b7fd51d9698715a36b79410a5ddb76

@poiana poiana added the approved label Sep 15, 2019
@fntlnz

This comment has been minimized.

Copy link
Member

fntlnz commented Sep 15, 2019

Thanks @sumitsaiwal

@fntlnz fntlnz requested a review from leodido Sep 15, 2019
@fntlnz fntlnz dismissed leodido’s stale review Sep 15, 2019

the author signed the commit

@fntlnz fntlnz merged commit 34654fd into falcosecurity:dev Sep 15, 2019
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Job Travis CI - Pull Request has not succeeded.
Travis CI - Pull Request Build Passed
Details
dco All commits have Signed-off-by
Details
@fntlnz fntlnz added this to the 0.18.0 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.