Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lua state access thread-safe #867

Merged
merged 2 commits into from Sep 30, 2019
Merged

Make lua state access thread-safe #867

merged 2 commits into from Sep 30, 2019

Conversation

@leodido
Copy link
Member

leodido commented Sep 30, 2019

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

We need that the concurrent access to Lua state is thread-safe.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: make lua state access thread-safe
leodido and others added 2 commits Sep 30, 2019
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido

This comment has been minimized.

Copy link
Member Author

leodido commented Sep 30, 2019

@poiana poiana requested review from fntlnz and kris-nova Sep 30, 2019
@kris-nova

This comment has been minimized.

Copy link
Member

kris-nova commented Sep 30, 2019

/lgtm

@poiana

This comment has been minimized.

Copy link

poiana commented Sep 30, 2019

LGTM label has been added.

Git tree hash: 98225db46657c08c70d32268e8defc7cdb76a839

@poiana poiana added the approved label Sep 30, 2019
Copy link
Member

kris-nova left a comment

Mutices are fun :)

@fntlnz
fntlnz approved these changes Sep 30, 2019
@poiana

This comment has been minimized.

Copy link

poiana commented Sep 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, kris-nova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fntlnz fntlnz merged commit 8a6c0b7 into dev Sep 30, 2019
3 of 4 checks passed
3 of 4 checks passed
tide Not mergeable. Job Travis CI - Pull Request has not succeeded.
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
dco All commits have Signed-off-by
Details
@poiana poiana deleted the fix/luastate-threadsaf branch Sep 30, 2019
@fntlnz fntlnz added this to the 0.18.0 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.