Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit catch2 dependency for tests #879

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@mstemm
Copy link
Contributor

mstemm commented Oct 7, 2019

When I try to build the dev branch using the docker builder, the tests
target isn't properly checking out and building catch2 for the
dependency catch2.hpp. Adding this explicit dependency allowed the build
to succeed.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

What this PR does / why we need it: Add explicit dependency between tests and catch2 header file.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add explicit dependency between tests and catch2 header file.
When I try to build the dev branch using the docker builder, the tests
target isn't properly checking out and building catch2 for the
dependency catch2.hpp. Adding this explicit dependency allowed the build
to succeed.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
@mstemm mstemm force-pushed the add-explicit-catch2-tests-dependency branch from f0a169d to 2c49e2a Oct 7, 2019
@mstemm mstemm requested a review from leodido Oct 7, 2019
@Kaizhe
Kaizhe approved these changes Oct 7, 2019
@poiana

This comment has been minimized.

Copy link

poiana commented Oct 7, 2019

LGTM label has been added.

Git tree hash: e2f0769df498bc958833d2622abe1838e078cb6a

@poiana poiana added the lgtm label Oct 7, 2019
@leodido
leodido approved these changes Oct 8, 2019
@fntlnz
fntlnz approved these changes Oct 8, 2019
@poiana

This comment has been minimized.

Copy link

poiana commented Oct 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, Kaizhe, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fntlnz fntlnz merged commit 1d1ecd9 into dev Oct 8, 2019
3 of 4 checks passed
3 of 4 checks passed
tide Not mergeable. Job Travis CI - Pull Request has not succeeded.
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
dco All commits have Signed-off-by
Details
@poiana poiana deleted the add-explicit-catch2-tests-dependency branch Oct 8, 2019
@fntlnz fntlnz added this to the 0.18.0 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.