Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use falcoctl 0.0.3 w/ unique names #895

Merged
merged 1 commit into from Oct 23, 2019
Merged

Use falcoctl 0.0.3 w/ unique names #895

merged 1 commit into from Oct 23, 2019

Conversation

@mstemm
Copy link
Contributor

mstemm commented Oct 21, 2019

Use the changes in falcosecurity/falcoctl#25
that make sure rules, macros, lists, and rule names all have a unique
prefix. In this case the prefix is based on the psp name, so make sure
the psp name actually reflects what it does--there were a few
cut-and-paste carryovers.

This test assumes that falcoctl will be tagged/released as 0.0.3--the
tests won't pass until the falcoctl PR is merged and there's a release.

Signed-off-by: Mark Stemm mark.stemm@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Allow for unique names for psp converted rules/macros/lists/rule names as generated by falcoctl 0.0.3
Use the changes in falcosecurity/falcoctl#25
that make sure rules, macros, lists, and rule names all have a unique
prefix. In this case the prefix is based on the psp name, so make sure
the psp name actually reflects what it does--there were a few
cut-and-paste carryovers.

This test assumes that falcoctl will be tagged/released as 0.0.3--the
tests won't pass until the falcoctl PR is merged and there's a release.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
@mstemm mstemm force-pushed the use-falcoctl-0_0_3 branch from 0b885d6 to 182e284 Oct 23, 2019
@fntlnz
fntlnz approved these changes Oct 23, 2019
Copy link
Member

fntlnz left a comment

Good job @mstemm thanks for making this better!

@poiana poiana added the lgtm label Oct 23, 2019
@poiana

This comment has been minimized.

Copy link

poiana commented Oct 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana

This comment has been minimized.

Copy link

poiana commented Oct 23, 2019

LGTM label has been added.

Git tree hash: d7757cfecacb606ab0a423dd9f09480b5c69194f

@poiana poiana added the approved label Oct 23, 2019
@mstemm mstemm merged commit d21e69c into dev Oct 23, 2019
3 of 4 checks passed
3 of 4 checks passed
tide Not mergeable. Job Travis CI - Pull Request has not succeeded.
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
dco All commits have Signed-off-by
Details
@poiana poiana deleted the use-falcoctl-0_0_3 branch Oct 23, 2019
@fntlnz fntlnz added this to the 0.18.0 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.