Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules update: expand list allowed_k8s_users #898

Merged
merged 1 commit into from Oct 24, 2019
Merged

Conversation

@Kaizhe
Copy link
Contributor

Kaizhe commented Oct 23, 2019

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:
Include default users created by kops.

Which issue(s) this PR fixes:
Some false positive are seen when k8s audit enabled

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rules: Include default users created by `kops`.
@poiana poiana requested review from fntlnz and leodido Oct 23, 2019
@poiana poiana added the size/XS label Oct 23, 2019
@Kaizhe Kaizhe force-pushed the rule-updates-2019-10.v1 branch 2 times, most recently from f6300c7 to 7d96db5 Oct 23, 2019
@poiana

This comment has been minimized.

Copy link

poiana commented Oct 24, 2019

LGTM label has been added.

Git tree hash: 56070f6ccf41320d9b559c42cee78eacc109432d

@fntlnz

This comment has been minimized.

Copy link
Member

fntlnz commented Oct 24, 2019

Thanks @Kaizhe I know a couple of users who will love this

Signed-off-by: kaizhe <derek0405@gmail.com>

add comments

Signed-off-by: kaizhe <derek0405@gmail.com>
@fntlnz fntlnz dismissed their stale review via def635b Oct 24, 2019
@fntlnz fntlnz force-pushed the rule-updates-2019-10.v1 branch from 7d96db5 to def635b Oct 24, 2019
@poiana poiana added lgtm and removed lgtm approved labels Oct 24, 2019
@fntlnz
fntlnz approved these changes Oct 24, 2019
@poiana

This comment has been minimized.

Copy link

poiana commented Oct 24, 2019

LGTM label has been added.

Git tree hash: 23538c07c6e2d54f12f69fa7c511f97bb0e57113

@poiana

This comment has been minimized.

Copy link

poiana commented Oct 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Oct 24, 2019
@fntlnz

This comment has been minimized.

Copy link
Member

fntlnz commented Oct 24, 2019

@Kaizhe I rebased this with dev so that the integration tests can pass, the dev you had as upstream had a problem with them.
Once travis is green we can merge!

@fntlnz fntlnz merged commit 5c61276 into dev Oct 24, 2019
3 of 4 checks passed
3 of 4 checks passed
tide Not mergeable. Job Travis CI - Pull Request has not succeeded.
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
dco All commits have Signed-off-by
Details
@poiana poiana deleted the rule-updates-2019-10.v1 branch Oct 24, 2019
@Kaizhe

This comment has been minimized.

Copy link
Contributor Author

Kaizhe commented Oct 24, 2019

Thank you @fntlnz

@fntlnz

This comment has been minimized.

Copy link
Member

fntlnz commented Oct 28, 2019

/milestone 0.18.0

@poiana poiana added this to the 0.18.0 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.