Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use falcoctl 0.0.4+ tests for space/dash psp names #899

Merged
merged 1 commit into from Oct 24, 2019
Merged

Conversation

@mstemm
Copy link
Contributor

mstemm commented Oct 24, 2019

Use falcoctl, which properly handles psp names containing
spaces/dashes. Also add tests that verify that the resulting rules are
valid.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add tests for psp conversions with names containing spaces/dashes.
Use falcoctl, which properly handles psp names containing
spaces/dashes. Also add tests that verify that the resulting rules are
valid.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
@mstemm mstemm force-pushed the use-falcoctl-0_0_4 branch from 38a05df to b18050d Oct 24, 2019
Copy link

rajibmitra left a comment

/lgtm

@poiana

This comment has been minimized.

Copy link

poiana commented Oct 24, 2019

LGTM label has been added.

Git tree hash: 7e14ca6b979be0d8a51d65e20dc7f3f4c6fea964

@poiana

This comment has been minimized.

Copy link

poiana commented Oct 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, rajibmitra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Oct 24, 2019
@leodido leodido merged commit daec9cb into dev Oct 24, 2019
3 of 4 checks passed
3 of 4 checks passed
tide Not mergeable. Needs approved label.
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
dco All commits have Signed-off-by
Details
@poiana poiana deleted the use-falcoctl-0_0_4 branch Oct 24, 2019
@fntlnz fntlnz added this to the 0.18.0 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.