Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Security Audit #977

Merged
merged 3 commits into from
Dec 17, 2019
Merged

Publish Security Audit #977

merged 3 commits into from
Dec 17, 2019

Conversation

mfdii
Copy link
Member

@mfdii mfdii commented Dec 17, 2019

What type of PR is this?

/kind documentation

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build
/area engine
/area rules

What this PR does / why we need it:
This publishes the Cure53 security audit findings.
Which issue(s) this PR fixes:

Fixes #886

Special notes for your reviewer:

Depends falco/falco-website#107.

Does this PR introduce a user-facing change?:

new: security audit

Signed-off-by: Michael Ducy <michael@ducy.org>
@caniszczyk
Copy link
Contributor

Thank you :)

Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we want to publish the audit file in a subdirectory?
This way we have a place for future ones. Following this logic we should also rename the audit file name including more info (at least the date imho)

WDYT? :)

Signed-off-by: Michael Ducy <michael@ducy.org>
Signed-off-by: Michael Ducy <michael@ducy.org>
@mfdii
Copy link
Member Author

mfdii commented Dec 17, 2019

@leodido made an audit folder, renamed with YEAR_MONTH

@poiana
Copy link

poiana commented Dec 17, 2019

LGTM label has been added.

Git tree hash: 648fd6f1ffeeccadcef04092666662d2bd97aa48

@poiana
Copy link

poiana commented Dec 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fntlnz fntlnz merged commit 2041932 into dev Dec 17, 2019
@poiana poiana deleted the mfdii/add_sec_audit branch December 17, 2019 08:15
@fntlnz fntlnz added this to the 0.19.0 milestone Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish security audit
5 participants