Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(index/remove): add output messages for index remove command #274

Merged
merged 1 commit into from Mar 30, 2023

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Mar 30, 2023

Furthermore debug messages are printed when --verbose flag is set.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area cli

/area tests

/area examples

What this PR does / why we need it:
Add output messages for falcoctl index remove command. The following snippet shows the outputs when running the command with `--verbose flag set to true:

❯ falcoctl index remove falcosecurity falcosecurity1 -v
 INFO  Creating in-memory cache using indexes file "/home/aldo/.config/falcoctl/indexes.yaml" and indexes directory "/home/aldo/.config/falcoctl/indexes"
 INFO  Removing index "falcosecurity"
 INFO  Removing index "falcosecurity1"
 INFO  Writing cache to disk
 INFO  Removing indexes entries from configuration file "/etc/falcoctl/falcoctl.yaml"
 INFO  Indexes successfully removed

Which issue(s) this PR fixes:
Give visibility to end users of what is happening under the hood when removing existing indexes.

Fixes #

Special notes for your reviewer:

Furthermore debug messages are printed when --verbose flag is set.

Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana
Copy link
Contributor

poiana commented Mar 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Mar 30, 2023

LGTM label has been added.

Git tree hash: 178329cc76be60b51d946f849bbed17ceae38555

@poiana poiana merged commit b0f1f27 into falcosecurity:main Mar 30, 2023
14 checks passed
@alacuku alacuku deleted the kcl/index-remove-output branch November 3, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants